[
https://issues.apache.org/jira/browse/FLINK-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014817#comment-16014817
]
ASF GitHub Bot commented on FLINK-6065:
---------------------------------------
GitHub user sschaef opened a pull request:
https://github.com/apache/flink/pull/3934
[FLINK-6065] Add initClient method to ElasticsearchApiCallBridge
This adds the method `initClient` to `ElasticsearchApiCallBridge` in
order to resolve FLINK-6065. This new method takes as argument a
function that can create a `TransportClient`. This is required in order
to not hardcode the `TransportClient` in the implementation of
`createClient`. `createClient` continues to exist in order to allow
backwards compatibility.
No tests provided because I couldn't find any existing test class that
tests the implementation of `ElasticsearchApiCallBridge`.
------------------------------------------------------------------------
This is my first contribution, I haven't signed the ICLA yet (which I will
do next). I didn't provide any tests yet because I had no idea how the
functionality should be tested or where a test class should be added. If you
would like to see tests for the changes, please tell me.
The change fixes the ticket but maybe you would like to see a different way
on how to fix the issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sschaef/flink flink-6065
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3934.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3934
----
commit 2815b0c9ca407838611ba60b9c35a0ac550005e3
Author: Simon Schäfer <m...@antoras.de>
Date: 2017-05-17T20:24:14Z
[FLINK-6065] Add initClient method to ElasticsearchApiCallBridge
This adds the method `initClient` to `ElasticsearchApiCallBridge` in
order to resolve FLINK-6065. This new method takes as argument a
function that can create a `TransportClient`. This is required in order
to not hardcode the `TransportClient` in the implementation of
`createClient`. `createClient` continues to exist in order to allow
backwards compatibility.
No tests provided because I couldn't find any existing test class that
tests the implementation of `ElasticsearchApiCallBridge`.
----
> Make TransportClient for ES5 pluggable
> --------------------------------------
>
> Key: FLINK-6065
> URL: https://issues.apache.org/jira/browse/FLINK-6065
> Project: Flink
> Issue Type: Improvement
> Components: ElasticSearch Connector, Streaming Connectors
> Reporter: Robert Metzger
>
> This JIRA is based on a user request:
> http://stackoverflow.com/questions/42807454/flink-xpack-elasticsearch-5-elasticsearchsecurityexception-missing-autentication?noredirect=1#comment72728053_42807454
> Currently, in the {{Elasticsearch5ApiCallBridge}} the
> {{PreBuiltTransportClient}} is hardcoded. It would be nice to make this
> client pluggable to allow using other clients such as the
> {{PreBuiltXPackTransportClient}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
