GitHub user sschaef opened a pull request:
https://github.com/apache/flink/pull/3934
[FLINK-6065] Add initClient method to ElasticsearchApiCallBridge
This adds the method `initClient` to `ElasticsearchApiCallBridge` in
order to resolve FLINK-6065. This new method takes as argument a
function that can create a `TransportClient`. This is required in order
to not hardcode the `TransportClient` in the implementation of
`createClient`. `createClient` continues to exist in order to allow
backwards compatibility.
No tests provided because I couldn't find any existing test class that
tests the implementation of `ElasticsearchApiCallBridge`.
------------------------------------------------------------------------
This is my first contribution, I haven't signed the ICLA yet (which I will
do next). I didn't provide any tests yet because I had no idea how the
functionality should be tested or where a test class should be added. If you
would like to see tests for the changes, please tell me.
The change fixes the ticket but maybe you would like to see a different way
on how to fix the issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sschaef/flink flink-6065
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3934.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3934
----
commit 2815b0c9ca407838611ba60b9c35a0ac550005e3
Author: Simon Schäfer <m...@antoras.de>
Date: 2017-05-17T20:24:14Z
[FLINK-6065] Add initClient method to ElasticsearchApiCallBridge
This adds the method `initClient` to `ElasticsearchApiCallBridge` in
order to resolve FLINK-6065. This new method takes as argument a
function that can create a `TransportClient`. This is required in order
to not hardcode the `TransportClient` in the implementation of
`createClient`. `createClient` continues to exist in order to allow
backwards compatibility.
No tests provided because I couldn't find any existing test class that
tests the implementation of `ElasticsearchApiCallBridge`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
