[
https://issues.apache.org/jira/browse/FLINK-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017234#comment-16017234
]
ASF GitHub Bot commented on FLINK-6065:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3934
Answer to some of your other questions:
1. I don't think the Apache ICLA is strictly required, unless you're
invited as a Committer of the project.
2. The tests should be added under `src/test/...` directory of the module.
I think the already-existing IT tests for the ES sinks already cover the
changed functionality here. Since this isn't a very complicated feature, for
new tests, at the very most I would suggest perhaps to add unit tests that test
the factory is correctly respected during the init flow.
> Make TransportClient for ES5 pluggable
> --------------------------------------
>
> Key: FLINK-6065
> URL: https://issues.apache.org/jira/browse/FLINK-6065
> Project: Flink
> Issue Type: Improvement
> Components: ElasticSearch Connector, Streaming Connectors
> Reporter: Robert Metzger
>
> This JIRA is based on a user request:
> http://stackoverflow.com/questions/42807454/flink-xpack-elasticsearch-5-elasticsearchsecurityexception-missing-autentication?noredirect=1#comment72728053_42807454
> Currently, in the {{Elasticsearch5ApiCallBridge}} the
> {{PreBuiltTransportClient}} is hardcoded. It would be nice to make this
> client pluggable to allow using other clients such as the
> {{PreBuiltXPackTransportClient}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
