Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r113047960
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,23 +62,28 @@ object AggregateUtil {
* @param generator code generator instance
* @param namedAggregates List of calls to aggregate functions and
their output field names
* @param inputType Input row type
+ * @param inputTypeInfo Input DataStream row type
+ * @param returnTypeInfo Return DataStream row type
* @param isRowTimeType It is a tag that indicates whether the time
type is rowTimeType
* @param isPartitioned It is a tag that indicate whether the input is
partitioned
* @param isRowsClause It is a tag that indicates whether the OVER
clause is ROWS clause
*/
- private[flink] def createUnboundedOverProcessFunction(
+ private[flink] def createUnboundedOverProcessFunction[T](
generator: CodeGenerator,
namedAggregates: Seq[CalcitePair[AggregateCall, String]],
inputType: RelDataType,
+ inputTypeInfo: TypeInformation[T],
--- End diff --
We don't need these types if we keep the code generation as it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
