vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2930557078


##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/FixedDepositProduct.java:
##########
@@ -78,6 +73,9 @@ public class FixedDepositProduct extends SavingsProduct {
     @JoinTable(name = "m_deposit_product_interest_rate_chart", joinColumns = 
@JoinColumn(name = "deposit_product_id"), inverseJoinColumns = @JoinColumn(name 
= "interest_rate_chart_id", unique = true))
     protected Set<InterestRateChart> charts;
 
+    @Transient
+    protected InterestRateChartAssembler chartAssembler;

Review Comment:
   Just because the function moved to that class doesn't mean it's now 
correct... why does this assembler thing (related to JSON) have to be in a 
(database related... different architecture layer!) entity class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to