vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2927354420
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartData.java:
##########
@@ -55,7 +57,7 @@ public final class InterestRateChartData {
public static InterestRateChartData instance(Long id, String name, String
description, LocalDate fromDate, LocalDate endDate,
boolean isPrimaryGroupingByAmount, Long savingsProductId, String
savingsProductName) {
Collection<EnumOptionData> periodTypes = null;
- Collection<InterestRateChartSlabData> chartSlabs = null;
+ Collection<InterestRateChartSlabData> chartSlabs = new ArrayList<>();
Review Comment:
Why do we have to initialize these and not the others? In fact "null" makes
a lot sense here. In general: let's be consistent (this here is not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
