vidakovic commented on code in PR #5613: URL: https://github.com/apache/fineract/pull/5613#discussion_r2927380611
########## fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/FixedDepositProduct.java: ########## @@ -42,18 +41,24 @@ import java.util.HashSet; import java.util.LinkedHashMap; import java.util.List; +import java.util.Locale; import java.util.Map; import java.util.Set; import org.apache.fineract.accounting.common.AccountingRuleType; import org.apache.fineract.infrastructure.core.api.JsonCommand; import org.apache.fineract.infrastructure.core.data.ApiParameterError; import org.apache.fineract.infrastructure.core.data.DataValidatorBuilder; import org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException; +import org.apache.fineract.infrastructure.core.service.DateUtils; import org.apache.fineract.organisation.monetary.domain.MonetaryCurrency; import org.apache.fineract.portfolio.charge.domain.Charge; import org.apache.fineract.portfolio.interestratechart.InterestRateChartApiConstants; +import org.apache.fineract.portfolio.interestratechart.domain.InterestIncentives; Review Comment: Absolute no-go... you are referencing here low level storage layer of the interest rate domain from the savings domain. Storage related classes are not supposed to "leak" outside of their domain. Just because you CAN access them here doesn't mean you SHOULD (and you really shouldn't). Needs a different solution, e.g. injecting a interest rate service. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
