vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2924460727
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/FixedDepositAccountsApiResource.java:
##########
@@ -446,7 +446,7 @@ private boolean is(final String commandParam, final String
commandValue) {
@Path("{accountId}")
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- @Operation(summary = "Delete a fixed deposit application", description =
"At present we support hard delete of fixed deposit application so long as its
in 'Submitted and pending approval' state. One the application is moves past
this state, it is not possible to do a 'hard' delete of the application or the
account. An API endpoint will be added to close/de-activate the fixed deposit
account.")
+ @Operation(summary = "Delete a fixed deposit application", description =
"At present we support hard fixedDepositProductDelete of fixed deposit
application so long as its in 'Submitted and pending approval' state. One the
application is moves past this state, it is not possible to do a 'hard'
fixedDepositProductDelete of the application or the account. An API endpoint
will be added to close/de-activate the fixed deposit account.")
Review Comment:
I think the refactoring tools went a bit overboard here when you renamed
those functions. I think the word "delete" was actually intended here. These
camel cased names make not much sense here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
