vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2924377456
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartReadServiceImpl.java:
##########
@@ -167,14 +146,14 @@ public InterestRateChartData template() {
final List<CodeValueData> clientClassificationOptions = new
ArrayList<>(
this.codeValueReadPlatformService.retrieveCodeValuesByCode(ClientApiConstants.CLIENT_CLASSIFICATION));
return
InterestRateChartData.template(this.chartDropdownReadPlatformService.retrievePeriodTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveEntityTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveAttributeNameOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveConditionTypeOptions(),
-
this.interestIncentiveDropdownReadPlatformService.retrieveIncentiveTypeOptions(),
genderOptions, clientTypeOptions,
+
this.interestIncentiveDropdownReadService.retrieveEntityTypeOptions(),
Review Comment:
Same here, see remarks concerning "this." usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
