vidakovic commented on code in PR #5613:
URL: https://github.com/apache/fineract/pull/5613#discussion_r2924308089
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/api/InterestRateChartsApiResource.java:
##########
@@ -138,51 +134,40 @@ public String retrieveOne(@PathParam("chartId")
@Parameter(description = "chartI
chartData =
this.chartReadPlatformService.retrieveWithTemplate(chartData);
}
- return this.toApiJsonSerializer.serialize(settings, chartData,
INTERESTRATE_CHART_RESPONSE_DATA_PARAMETERS);
+ return this.jsonSerializer.serialize(settings, chartData,
INTERESTRATE_CHART_RESPONSE_DATA_PARAMETERS);
Review Comment:
As soon as there is "JsonSerializer" or "JsonHelper" or the like: nope. Not
necessary. Return the proper types on those JAX-RS functions and Jackson will
take care of this, not a single line of additional code necessary... and then
we can get rid of this JSON related boilerplate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
