bmarsaud commented on code in PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1675666901
##########
src/android/Capture.java:
##########
@@ -234,7 +234,7 @@ private JSONObject getAudioVideoData(String filePath,
JSONObject obj, boolean vi
return obj;
}
- private boolean isMissingPermissions(Request req, ArrayList<String>
permissions) {
+ private boolean isMissingPermissions(Request req, List<String>
permissions) {
Review Comment:
Aren't every list in JAVA ordered? In the sense that the iteration is always
deterministic.
Here, you give a list that is ordered as you wish it to be, we don't need to
constrain to use a particular implementation of `List` : the reponsability of
the order is for the caller.
In our very case, we use `Arrays.asList` that keeps the same order as the
initial array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
