ath0mas commented on code in PR #295:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1649753021
##########
src/android/Capture.java:
##########
@@ -234,7 +234,7 @@ private JSONObject getAudioVideoData(String filePath,
JSONObject obj, boolean vi
return obj;
}
- private boolean isMissingPermissions(Request req, ArrayList<String>
permissions) {
+ private boolean isMissingPermissions(Request req, List<String>
permissions) {
Review Comment:
I think the `ArrayList` is "expected" here, as an ordered collection, and so
should not be replaced by `List`.
And if I am correct Android expects the permissions to be requested in
order, like let's say READ before WRITE, or location before background/always
location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
