bmarsaud commented on code in PR #295: URL: https://github.com/apache/cordova-plugin-media-capture/pull/295#discussion_r1650993976
########## plugin.xml: ########## @@ -78,11 +78,8 @@ xmlns:android="http://schemas.android.com/apk/res/android"; <config-file target="AndroidManifest.xml" parent="/*"> <uses-permission android:name="android.permission.RECORD_AUDIO" /> - <uses-permission android:name="android.permission.READ_MEDIA_AUDIO" /> - <uses-permission android:name="android.permission.READ_MEDIA_IMAGES" /> - <uses-permission android:name="android.permission.READ_MEDIA_VIDEO" /> - <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32" /> - <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="32" /> + <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="29" /> + <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="29" /> Review Comment: Maybe I don't have the full picture here, but I'm pretty sure we don't need this permission for Android 29+ for **medias** as stated in the following documentation : https://developer.android.com/training/data-storage/shared/media?hl=en#storage-permission and regarding the tests that I have performed. Whats bugs me is that it add a permission popup on the first media capture intent. Anyway, do you want me to rollback `android:maxSdkVersion="32"` ? ########## plugin.xml: ########## @@ -78,11 +78,8 @@ xmlns:android="http://schemas.android.com/apk/res/android"; <config-file target="AndroidManifest.xml" parent="/*"> <uses-permission android:name="android.permission.RECORD_AUDIO" /> - <uses-permission android:name="android.permission.READ_MEDIA_AUDIO" /> - <uses-permission android:name="android.permission.READ_MEDIA_IMAGES" /> - <uses-permission android:name="android.permission.READ_MEDIA_VIDEO" /> - <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32" /> - <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="32" /> + <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="29" /> + <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="29" /> Review Comment: Maybe I don't have the full picture here, but I'm pretty sure we don't need this permission for Android 29+ for **medias** as stated in the following documentation : https://developer.android.com/training/data-storage/shared/media?hl=en#storage-permission and regarding the tests that I have performed. Whats bugs me is that it add a permission popup on the first media capture intent. Anyway, do you want me to rollback to `android:maxSdkVersion="32"` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
