dpogue commented on code in PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#discussion_r1179447984
########## templates/project/res/xml/opener_paths.xml: ########## @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- https://developer.android.com/reference/android/support/v4/content/FileProvider.html#SpecifyFiles --> +<paths xmlns:android="http://schemas.android.com/apk/res/android";> Review Comment: hmm, so the file needs to exist, and probably needs at least one path defined... I guess one option would be for cordova-android to provide a default (mostly empty) implementation of this file, and then we update the cordova-plugin-file to use `edit-config` to add the rest of the paths at install time. That would only really work with major bumps to both cordova-android and cordova-plugin-file, but we're looking at a major for this repo anyways. @erisu @breautek Thoughts? Are there downsides or security risks to including all these paths here by default? I'm not too familiar with Android's FileProvider stuff 😕 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
