breautek commented on code in PR #1609:
URL: https://github.com/apache/cordova-android/pull/1609#discussion_r1178389629
##########
framework/src/org/apache/cordova/engine/SystemWebChromeClient.java:
##########
@@ -211,54 +216,137 @@ public View getVideoLoadingProgressView() {
return mVideoProgressView;
}
+ // <input type=file> support:
+ // openFileChooser() is for pre KitKat and in KitKat mr1 (it's known
broken in
+ // KitKat).
+ // For Lollipop, we use onShowFileChooser().
Review Comment:
Kitkat (Android 4.4 / API 19) was indeed dropped since cordova-android@10.
Lollipop (Android 5.0 / API 21) is being dropped in the next release in
cordova-android@12, which will hvae a Min SDK of 24 (Android 7 / Nougat)
But I assume
[onShowFileChooser](https://developer.android.com/reference/android/webkit/WebChromeClient#onShowFileChooser(android.webkit.WebView,%20android.webkit.ValueCallback%3Candroid.net.Uri[]%3E,%20android.webkit.WebChromeClient.FileChooserParams))
is to be used for API 21+, so I think it's still relevant. It's not deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
