KenCorbettJr commented on code in PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#discussion_r1179369821
########## framework/src/org/apache/cordova/engine/SystemWebChromeClient.java: ########## @@ -211,54 +216,137 @@ public View getVideoLoadingProgressView() { return mVideoProgressView; } + // <input type=file> support: + // openFileChooser() is for pre KitKat and in KitKat mr1 (it's known broken in + // KitKat). + // For Lollipop, we use onShowFileChooser(). Review Comment: Nice. Then we can just remove all this code. I will delete it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org