[
https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968893#comment-14968893
]
ASF GitHub Bot commented on CLOUDSTACK-8975:
--------------------------------------------
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150168452
@miguelaferreira - we have discussed this on an earlier email. as Prashant
said, In this case a test case is skipped because the setup does not have the
configuration needed for the test to run. the test will fail if the
configuration is incorrect. From that sense, IMHO - test setup method is not
coded to handle the possibility of configuration not being present and hence
needs a fix.
Just my 2 cents, I would like to skip a test if I don't have the
configuration. As a person running the BVTs, I will check all the test status
and cannot ignore skipped tests. Also, BVTs are run every time when the build
is kicked off. If people keep adding their own tests which not everyone can
run then the importance of BVTs is gone and we will never achieve 100%
passrate. If someone has specific tests they want to run, keep it in a
different folder and not keep it in smoke folder. Also, skipping tests is
designed for a purpose.
@runseb we should establish some ground rules around BVTs otherwise we will
have to do conditional coding for running tests which is hard to maintain.
> [Automation]skip test case if niciraNvp settings are not available in config
> file
> ---------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8975
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation
> Affects Versions: 4.7.0
> Reporter: prashant kumar mishra
> Assignee: prashant kumar mishra
> Priority: Minor
> Fix For: 4.7.0
>
>
> /root/cloudstack/test/integration/smoke/test_nicira_controller.py is
> failing if niciraNvp settings are not available in config file. Modifying
> script to skip test case if settings are not available
> log
> =======
> File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py",
> line 46, in setUpClass
> cls.nicira_hosts = cls.config.niciraNvp.hosts
> AttributeError: 'NoneType' object has no attribute 'hosts'
> -------------------- >> begin captured stdout << ---------------------
> === TestName: None | Status : EXCEPTION ===
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
