[
https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968865#comment-14968865
]
ASF GitHub Bot commented on CLOUDSTACK-8975:
--------------------------------------------
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150161922
@miguelaferreira i was going though mail thread and found this
"I think the test should fail if the config is not right, or otherwise be
excluded if the indentation is to not run them."
My comment
1-For not right nicira settings , test case will fail
2-It will skip only if nicira settings are not present in config file
skipping test case or excluding it from a run ?
I would prefer skipping based on config file with proper message in test
results .
To exclude test file you have to modify the job which will be painful
if i have to do it for a number of test scripts .
> [Automation]skip test case if niciraNvp settings are not available in config
> file
> ---------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8975
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation
> Affects Versions: 4.7.0
> Reporter: prashant kumar mishra
> Assignee: prashant kumar mishra
> Priority: Minor
> Fix For: 4.7.0
>
>
> /root/cloudstack/test/integration/smoke/test_nicira_controller.py is
> failing if niciraNvp settings are not available in config file. Modifying
> script to skip test case if settings are not available
> log
> =======
> File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py",
> line 46, in setUpClass
> cls.nicira_hosts = cls.config.niciraNvp.hosts
> AttributeError: 'NoneType' object has no attribute 'hosts'
> -------------------- >> begin captured stdout << ---------------------
> === TestName: None | Status : EXCEPTION ===
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
