[
https://issues.apache.org/jira/browse/CLOUDSTACK-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968870#comment-14968870
]
ASF GitHub Bot commented on CLOUDSTACK-8975:
--------------------------------------------
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150162817
@nitt10prashant I rather not skip at all. There are just too many examples
of tests being skipped and people not reviewing the output. And that's not even
the worse case scenario! This week I made a PR, I got ! LGTM, Jenkins was
green, travis was green and maven wouldn't even compile the project because I
broke it. Builds and test runs breaking when something is not good is what we
need.
And in all fairness, this whole discussion is about not having to give any
thought to which test will run in someone's builds. Why go through all this
trouble just to be able to run all tests in the `test/integration` directory?
Will that make ACS better?
Take the time to figure out which tests you want to run, and if you don't
want to run this one, just don't include it in you build!
> [Automation]skip test case if niciraNvp settings are not available in config
> file
> ---------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8975
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation
> Affects Versions: 4.7.0
> Reporter: prashant kumar mishra
> Assignee: prashant kumar mishra
> Priority: Minor
> Fix For: 4.7.0
>
>
> /root/cloudstack/test/integration/smoke/test_nicira_controller.py is
> failing if niciraNvp settings are not available in config file. Modifying
> script to skip test case if settings are not available
> log
> =======
> File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py",
> line 46, in setUpClass
> cls.nicira_hosts = cls.config.niciraNvp.hosts
> AttributeError: 'NoneType' object has no attribute 'hosts'
> -------------------- >> begin captured stdout << ---------------------
> === TestName: None | Status : EXCEPTION ===
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
