[
https://issues.apache.org/jira/browse/ARTEMIS-5871?focusedWorklogId=1003524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1003524
]
ASF GitHub Bot logged work on ARTEMIS-5871:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/26 17:17
Start Date: 04/Feb/26 17:17
Worklog Time Spent: 10m
Work Description: gtully commented on PR #6205:
URL: https://github.com/apache/artemis/pull/6205#issuecomment-3848720073
I agree that config reload with a provided programmatic config is broken.
There are no callbacks and have been no callbacks for programmatic config to
get reapplied.
That is not an argument for not restricting the reload of properties config
to re loadable components.
The fact that the effective config was changing on reload is irrelevant
unless something reads the new config. The only thing that rereads config are
the components that support config reload when they are poked on reload.
Issue Time Tracking
-------------------
Worklog Id: (was: 1003524)
Time Spent: 3h (was: 2h 50m)
> reload of broker properties config should be restricted to confined to
> re-loadable components
> ---------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5871
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5871
> Project: Artemis
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.50.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> currently on reload config, broker properties are applied to the current
> broker config in error.
> This means that the absence of a value is not reflected in the config update,
> simply removing the properties does not result in a removed component or
> configuration entry.
> This is not consistent with the xml reload but also means for properties only
> config, there needs to be an explicit remove key=- value. which then needs to
> be removed.
> If config reload of properties are confined to a new config that is then
> compared in the normal way with the component reload logic, the properties
> can be the source of truth.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
