[
https://issues.apache.org/jira/browse/ARTEMIS-5871?focusedWorklogId=1003456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1003456
]
ASF GitHub Bot logged work on ARTEMIS-5871:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/26 12:26
Start Date: 04/Feb/26 12:26
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #6205:
URL: https://github.com/apache/artemis/pull/6205#issuecomment-3847148631
> configurationFileRefreshPeriod=-1 is necessary if there are multiple
source of truth for config that supports reload.
> configurationFileRefreshPeriod=-1 is necessary if there are multiple
source of truth for config that supports reload.
This has never been a stated requirement and still wouldnt be enforced
(which it should be if its a requirement), and I know you originally added the
broker properties to use in a situation there were specifically multiple
sources (with updates to each targeting different configuration areas, i.e not
overlapping) so that seems strange to say now. I can see it causes problems for
your current changes, but I dont think silently breaking stuff that has been
working is necessarily the way to go. I also think what these changes would
seem to allow in later silently tossing startup configuration would be a worse
bug than any consideration of the way it currently behaves as being a bug.
Issue Time Tracking
-------------------
Worklog Id: (was: 1003456)
Time Spent: 1h 50m (was: 1h 40m)
> reload of broker properties config should be restricted to confined to
> re-loadable components
> ---------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5871
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5871
> Project: Artemis
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.50.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> currently on reload config, broker properties are applied to the current
> broker config in error.
> This means that the absence of a value is not reflected in the config update,
> simply removing the properties does not result in a removed component or
> configuration entry.
> This is not consistent with the xml reload but also means for properties only
> config, there needs to be an explicit remove key=- value. which then needs to
> be removed.
> If config reload of properties are confined to a new config that is then
> compared in the normal way with the component reload logic, the properties
> can be the source of truth.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
