[
https://issues.apache.org/jira/browse/ARTEMIS-5871?focusedWorklogId=1003472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1003472
]
ASF GitHub Bot logged work on ARTEMIS-5871:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/26 13:06
Start Date: 04/Feb/26 13:06
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #6205:
URL: https://github.com/apache/artemis/pull/6205#issuecomment-3847352851
> This is not a change of expected behaviour, config reload has always
tossed startup config. That is how it works, such that the config taken at
startup can be compared to the new config. It has never been the case that
programmatic config is safe from config reload. disabling config reload is only
necessary if you don't want reload to take precedence.
We have a different definition of 'change' then. It has been the case that
programmatic config which hasnt changed by the properties has been safe from
_properties config_ reload previously, given the way the properties config
[reload] always worked at startup and later. It plays partly into the same
space that meant you previously added a mechanism that allow 'unsetting'
existing config by adding a 'removal property' value, which is partly what you
look to be trying to change here.
Issue Time Tracking
-------------------
Worklog Id: (was: 1003472)
Time Spent: 2h 20m (was: 2h 10m)
> reload of broker properties config should be restricted to confined to
> re-loadable components
> ---------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5871
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5871
> Project: Artemis
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.50.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> currently on reload config, broker properties are applied to the current
> broker config in error.
> This means that the absence of a value is not reflected in the config update,
> simply removing the properties does not result in a removed component or
> configuration entry.
> This is not consistent with the xml reload but also means for properties only
> config, there needs to be an explicit remove key=- value. which then needs to
> be removed.
> If config reload of properties are confined to a new config that is then
> compared in the normal way with the component reload logic, the properties
> can be the source of truth.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
