[
https://issues.apache.org/jira/browse/IMPALA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930231#comment-17930231
]
ASF subversion and git services commented on IMPALA-13694:
----------------------------------------------------------
Commit 1c764c6f524a7593078125b3cba16a7948c1bf3b in impala's branch
refs/heads/branch-4.5.0 from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1c764c6f5 ]
IMPALA-13761: Fix test_coord_only_pool_exec_groups
IMPALA-13201 adds test_coord_only_pool_exec_groups. This test failed in
TestAdmissionControllerWithACService due to unaccounted AdmissionD as
the extra statestore subscriber. This patch fix the issue by using
expected_subscribers and expected_num_impalads argument for
CustomClusterTestSuite._start_impala_cluster() and relies on wait
mechanism inside it.
This patch also does some adjustments:
1. Tweak __run_assert_systables_query to not use
execute_query_using_vector from IMPALA-13694.
2. Remove default_impala_client() call, first added by IMPALA-13668, and
use self.client instead.
3. Fixed minor flake8 issue at test_coord_only_pool_happy_path.
These make it possible to backport IMPALA-13201 and IMPALA-13761
together to older release/maintenance branch.
Testing:
Run the test with this command:
impala-py.test --exploration=exhaustive \
-k test_coord_only_pool custom_cluster/test_admission_controller.py
Change-Id: I00b83e706aca3325890736133b2d1dcf735b19df
Reviewed-on: http://gerrit.cloudera.org:8080/22486
Reviewed-by: Peter Rozsa <[email protected]>
Reviewed-by: Jason Fehr <[email protected]>
Tested-by: Jason Fehr <[email protected]>
> Add ImpalaConnection.reset_configuration method.
> ------------------------------------------------
>
> Key: IMPALA-13694
> URL: https://issues.apache.org/jira/browse/IMPALA-13694
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 4.6.0
>
>
> ImpalaTestSuite.run_test_case() reuse ImpalaConnection and restore its
> configuration at the end of test via
> ImpalaTestSuite.__restore_query_options(). We should make restoring query
> options to default value generic inside ImpalaConnection. Currently,
> ImpalaConnection has set_configuration, set_configuration_option,
> get_default_configuration, and clear_configuration method, but there is no
> reset_configuration method.
> Impala py.test code should also consistently lower case query options names
> everywhere, following standard set by IMPALA-13319.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
