[
https://issues.apache.org/jira/browse/IMPALA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921587#comment-17921587
]
Riza Suminto commented on IMPALA-13694:
---------------------------------------
I initially think that I can simply feeding
ImpalaConnection.get_default_configuration() back to
ImpalaConnection.set_configuration(). But that comes with 2 issue:
# The execute_query payload after
client.set_configuration(client.get_default_configuration()) will be
unnecessarily big because the RPC will contain all query options set, albeit
with default value.
# ImpalaConnection.get_default_configuration() contains REMOVED options that
is invalid to use anymore.
Simpler approach is to just clear_configuration() every time at setup_method().
> Add ImpalaConnection.reset_configuration method.
> ------------------------------------------------
>
> Key: IMPALA-13694
> URL: https://issues.apache.org/jira/browse/IMPALA-13694
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> ImpalaTestSuite.run_test_case() reuse ImpalaConnection and restore its
> configuration at the end of test via
> ImpalaTestSuite.__restore_query_options(). We should make restoring query
> options to default value generic inside ImpalaConnection. Currently,
> ImpalaConnection has set_configuration, set_configuration_option,
> get_default_configuration, and clear_configuration method, but there is no
> reset_configuration method.
> Impala py.test code should also consistently lower case query options names
> everywhere, following standard set by IMPALA-13319.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
