[
https://issues.apache.org/jira/browse/IMPALA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928528#comment-17928528
]
ASF subversion and git services commented on IMPALA-13694:
----------------------------------------------------------
Commit 7373ee27d43fe9ce7d89691764b388db7ecf05ac in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7373ee27d ]
IMPALA-13752: Remove option value quoting in __restore_query_options
Second run of test_parquet_late_materialization with codegen enabled
failed because ENABLED_RUNTIME_FILTER_TYPES option failed to restored
back to its default value, "BLOOM,MINMAX".
The root cause is the new collect_default_query_options() function in
impala_connection.py, added by IMPALA-13694. It will automatically wrap
list values in double quote. Consequently,
ImpalaTestSuite.__restore_query_options() does not need to wrap option
value with another single quote.
This patch also fix missing handling of optional query option without
any default value.
Testing:
Run the test with this command:
impala-py.test --exploration=exhaustive \
-k test_parquet_late_materialization \
query_test/test_parquet_late_materialization.py
Change-Id: I004ca021f64ffcc0c3d4cb2bb4aa550012b1be20
Reviewed-on: http://gerrit.cloudera.org:8080/22488
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Add ImpalaConnection.reset_configuration method.
> ------------------------------------------------
>
> Key: IMPALA-13694
> URL: https://issues.apache.org/jira/browse/IMPALA-13694
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 4.6.0
>
>
> ImpalaTestSuite.run_test_case() reuse ImpalaConnection and restore its
> configuration at the end of test via
> ImpalaTestSuite.__restore_query_options(). We should make restoring query
> options to default value generic inside ImpalaConnection. Currently,
> ImpalaConnection has set_configuration, set_configuration_option,
> get_default_configuration, and clear_configuration method, but there is no
> reset_configuration method.
> Impala py.test code should also consistently lower case query options names
> everywhere, following standard set by IMPALA-13319.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
