Hi,
I don't think it'll improve something, and may complicate merging from PHP5
(this is not a big issue, because merging is already not simple).
In any case, the names should be swapped, to be used as:
php_error_docref(E_WARNING, "recursion detected");
or
php_error_docref_ex(NULL, E_WARNING, "recursion detected");
also macros with __VA_ARGS__ may be not portable, s it should be
implemented differently.
Thanks. Dmitry.
On Wed, Feb 11, 2015 at 11:41 AM, Xinchen Hui <larue...@php.net> wrote:
> Hey:
>
> On Wed, Feb 11, 2015 at 4:35 PM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote:
> > Hi all,
> >
> > On Wed, Feb 11, 2015 at 5:21 PM, reeze <re...@php.net> wrote:
> >>
> >> I think it is a cleanup, it works but there are too many duplication. it
> >> is the time to make the code clean and easier to understand.
> >
> >
> > I've never used other than NULL also.
> > Everyone is going to remove TSRM macros, it's right time to clean up.
> fine, if you want to change..
>
> please, _ex means extending,
>
> so the name should not be php_error_docref_ex...
>
> thanks
> >
> > Regards,
> >
> > --
> > Yasuo Ohgaki
> > yohg...@ohgaki.net
>
>
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>
