> On 4 Dec 2014, at 05:51, Xinchen Hui <larue...@php.net> wrote: > >> > I am not sure if I misunderstand your proposal.. > > I thought you proposal is only fail if double value is out of long range > > but from your patch, ext/date/tests/date_sunset_variation9.phpt is > fails with a double value 12.*** (which is obviously not out of long > range).
That one caught me out too! Look more carefully, I missed it the first time. 12.3456789000e10 has a sneaky “e10” at the end, so it’s more like 123456789000 ;) -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
