Well, there are two changes there (not sure why "move zlog_set_level() again shows up twice in the log"?)
One changes the pm.start_servers calculated default message to a notice (makes total sense IMO). The other moves zlog_set_level() so it's called earlier, or else the log level isn't set yet at the moment the notice/warning above is issued. You did merge the very similar other PR (894) to 5.5, where zlog_set_level() was already moved to an earlier stage to fix a similar issue (where messages like "user ignored when not running as root" would be emitted regardless of log_level). So in the interest of behavioral consistency between the two versions, I'd say merge at least the zlog_set_level() move, but the pm.start_servers change is not comparable to the IPv6 breakage because it doesn't change any logic, and we now have tests in 5.6. David On 20.11.2014, at 10:34, Remi Collet <r...@fedoraproject.org> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I think the situation is now better. > > At least test suite grow from 3 to 15 tests (+1 for Apparmor) > and all recent bugs / changes are covered. > > Notice: test suite is 5.6+ only as rely on --force-stderr > > > Some minor changes are 5.6+ only > > 09f9f7ce5030973052bca5043425bd9f20ad7a7e move zlog_set_level() again > 7e0ccb6d1217b6738117ab19590444fec9d0951a warning to notice > 909d44f20dd00ccf3a6519707bfaba2ed30e8b2b move zlog_set_level() again > 914787491d78cded722318d0796b13f11cb197f8 warning when multiple addr > > I was asked (by the author of the 3 firsts) to also apply them in 5.5 > > What do you think ? > > I'm a bit relunctant, because we already have so much changes... > but in all cases we'll need a big test/QA for FPM in 5.5.20 / 5.6.4. > > > Remi. > > P.S. Still TODO: listen_allowed_clients is now aware of IPv4/IPv6, but > it could make sense to make it aware of hostname (using getaddrinfo), > and set all found addresses as allowed. Probably not urgent. > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iEYEARECAAYFAlRttbEACgkQYUppBSnxahgzFwCeM7YJQ+G07RtZSyn1vtH0QOn3 > XxIAniVlKn1YhGFMT6bWq3RojOeYSr0K > =tULN > -----END PGP SIGNATURE----- > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
