2014.11.15. 8:28 ezt írta ("Remi Collet" <r...@fedoraproject.org>): > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > FPM state in 5.5.19 / 5.6.3 is quite bad :( > > I just fix: > > https://bugs.php.net/68420 > listen=9000 listens to ipv6 localhost instead of all addresses > > This is obviously a regression. > Ok, workaround exists, using explicit address which seems the food > practice. > > https://bugs.php.net/68421 > access.format='%R' doesn't log ipv6 address > > Not a big issue.. but need to be fixed, related to the new feature > > https://bugs.php.net/68423 > PHP-FPM will no longer load all pools > > This is obviously another regression which break multi-pool configuration. > > I don't really know how we can improve our workflow to avoid such > regression, but it seems needed to enlight such new features in RC > annoucement (even if they could seems trivial), especially when > allowed in stable branch. > > > SO PLEASE, everyone who can test these patches, please test and give > feedback [1] > > Cheers, > Remi > > > P.S. I will be mostly offline for the week-end, but I plan to rebuild > the Fedora packages ASAP, and before they go in stable repo. > > [1] especially for 68423 as it seems the reporter say it is not fixed, > while another user (of my RPM) say it is. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iEYEARECAAYFAlRnAHUACgkQYUppBSnxahjV5QCg8286koxtzZskY6zHpOek1nyK > GG0An15snTCRkqyLLhJdUhMduVe1BR2/ > =xCFe > -----END PGP SIGNATURE----- > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
Yeah, the test coverage of fpm is lacking, and while this PR contained a test for testing the happy path (that you can listen on ipv6) but there were no tests which could have helped us to spot the problems introduced with the change. I will make sure to have phpt-s for the reported problems and will also try to extend the current coverage and I would be glad if others could also help with that.