On Mon, Nov 17, 2014 at 4:24 PM, Remi Collet <r...@fedoraproject.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Le 15/11/2014 11:11, Ferenc Kovacs a écrit : > > > Yeah, the test coverage of fpm is lacking, and while this PR > > contained a test for testing the happy path (that you can listen on > > ipv6) but there were no tests which could have helped us to spot > > the problems introduced with the change. > > The main issue with the FPM test suite, is that we need to be able to > run small FactCGI request. > > Proposal : include the "small" FastCGI client library from > https://github.com/adoy/PHP-FastCGI-Client and use it. > > See attached patch which add 3 tests (covering some of the recent bugs). > > Do you think it is Ok ? > > > Remi. > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iEYEARECAAYFAlRqEyIACgkQYUppBSnxahjAQwCcDpTViQ59y6/nQuD+w4Rv9Wl2 > xf0AoOogKnZwZmrVQPJ62LAEpSvOhaM2 > =zHh0 > -----END PGP SIGNATURE----- > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > As it is pretty small/lightweight(single class) and has MIT license, I think it should be fine including it. Thanks for looking into these! -- Ferenc Kovács @Tyr43l - http://tyrael.hu
