We are in an intermediate step right now where you are commiting these macros to make sure that review of GC is easier. There'll be a period of testing, benchmarks and stabilizing which we need to go through. Only after that will we figure out what we'd like to do. Do we want to always enable it, make it a config parameter or a compile-time option. All options are open the way I see it so let's make the right steps accordingly. Just randomly breaking source code compatibility at this point for no reason doesn't make sense.
Btw, I agree that we will want to make sure that the macros are used and we will find a way to do that. Andi > -----Original Message----- > From: David Wang [mailto:[EMAIL PROTECTED] > Sent: Friday, September 07, 2007 8:38 AM > To: Cristian Rodriguez > Cc: internals@lists.php.net > Subject: Re: [PHP-DEV] Patch for macros for tracking refcount and > is_ref > > > ps: remember to change the Zend/PHP API number as well ;) > > Done. > > I personally think having a ZEND_GC switch sort of defeats the purpose > of forcing everyone to start using the macros (whether or not we want > the GC), which is something we want to do anyway. However, here are > the two versions of the patch, for everyone's consideration: > > With ZEND_GC: http://zoo.cs.yale.edu/~yw226/macros.diff.txt > Without: http://zoo.cs.yale.edu/~yw226/macros2.diff.txt > > David > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
