Hi David, In general the patch is fine. The only thing which I'd like to change is to make sure the __gc naming is in an #if ZEND_GC for now otherwise we'll be breaking lots of third party libraries and PECL extensions.
Andi > -----Original Message----- > From: David Wang [mailto:[EMAIL PROTECTED] > Sent: Wednesday, September 05, 2007 10:47 PM > To: Marcus Boerger > Cc: Nuno Lopes; internals@lists.php.net; [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] Patch for macros for tracking refcount and > is_ref > > > In my own code, I have a "__gc" on refcount and is_ref so I get > thrown > > an error if there's a place I failed to macroize. I removed that for > > this patch, but that's a very good point. If there are no objections, > > that or another prefix or suffix can be put back into the patch. > > I've posted another version of the patch with the __gc suffix at > http://zoo.cs.yale.edu/~yw226/macros2.diff.txt > > The GC patch is also ready. As soon as the macros patch has been > finalized and committed, I will send that out to the mailing list. > > David -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
