On Thu, 6 Sep 2007, Andi Gutmans wrote: > In general the patch is fine. > The only thing which I'd like to change is to make sure the __gc naming > is in an #if ZEND_GC for now otherwise we'll be breaking lots of third > party libraries and PECL extensions.
But you might want to wonder if that's not a good thing? Without the prefix there will be no indication for third party extensions that they might be doing something that's not going to work nicely with the new GC anymore. I'd prefer it to have the __gc always there. Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
