On the other hand, if code IS working stably then it may be better to leave it alone. I'm not saying don't tidy up code, but ALL the tests against a change need to be in place before a change is applied to the live code, and in some cases it is worth remembering that PHP *IS* multi-platform. Some changes tailored for one environment may be a disaster in another - code for the 'safe' ground.
As Alexander's initial re-implementation of crc32() was broken on 64-bit architectures, I think this is a very good point.
-- Ard
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
