On Thu, 2025-06-26 at 11:20 +0300, Imre Deak wrote: > From: Imre Deak <imre.d...@gmail.com> > > The device service IRQ handling was added to the connector detect > function by > > commit 09b1eb130e43 ("drm/i915: Move Displayport test request and sink > IRQ logic to intel_dp_detect()") > > since some Automated Test Request IRQs couldn't be handled in the short > HPD IRQ handler context. This has been fixed meanwhile by deferring the > handling of all test request events from the IRQ handler to the hotplug > handler (intel_dp_short_pulse() -> intel_dp_test_short_pulse() -> > reprobe) and by handling all hotplug events (both for short and long HPD > pulses) in the test application. > > Handling device IRQs during connector detection is not standard > compliant (the IRQs should be handled when an HPD IRQ is raised) and it > happens in a racy way with the same device IRQ handling happening from > the HPD IRQ handler (since the detect and HPD IRQ handler can run in > parallel). > > Based on the above, remove the redundant call from the detect function. > > Signed-off-by: Imre Deak <imre.d...@gmail.com> > ---
Reviewed-by: Luca Coelho <luciano.coe...@intel.com> -- Cheers, Luca.