On Thu, 2025-06-26 at 11:20 +0300, Imre Deak wrote: > From: Imre Deak <imre.d...@gmail.com> > > The DP_LINK_SERVICE_IRQ_VECTOR_ESI0 DPCD register is supported only > since DPCD REV 1.2, so fix the revision check accordingly. > > Signed-off-by: Imre Deak <imre.d...@gmail.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index 6262b661d026e..7793a72983abd 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -5420,7 +5420,7 @@ static bool intel_dp_check_link_service_irq(struct > intel_dp *intel_dp) > bool reprobe_needed = false; > u8 val; > > - if (intel_dp->dpcd[DP_DPCD_REV] < 0x11) > + if (intel_dp->dpcd[DP_DPCD_REV] < DP_DPCD_REV_12) > return false; > > if (drm_dp_dpcd_readb(&intel_dp->aux,
At first I was confused by the revision being in "decimal hex", but then I realized that the revisions are actually using fixed point representation. IMHO the macros would be more intuitive if they were called, e.g. DP_DCPD_REV_1_2. But this is orthogonal to this patch. Reviewed-by: Luca Coelho <luciano.coe...@intel.com> -- Cheers, Luca.
