From: Ville Syrjälä <ville.syrj...@linux.intel.com>

The formula in Bspec for computing the overlay SWIDTHSW is overly
obfuscated. Simplify the formula to something that's easily parsed by
humans.

Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_overlay.c | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_overlay.c 
b/drivers/gpu/drm/i915/intel_overlay.c
index 10e8d3b9a0c4..19ff5d86f9f9 100644
--- a/drivers/gpu/drm/i915/intel_overlay.c
+++ b/drivers/gpu/drm/i915/intel_overlay.c
@@ -566,19 +566,17 @@ static int uv_vsubsampling(u32 format)
 
 static u32 calc_swidthsw(struct drm_i915_private *dev_priv, u32 offset, u32 
width)
 {
-       u32 mask, shift, ret;
-       if (IS_GEN2(dev_priv)) {
-               mask = 0x1f;
-               shift = 5;
-       } else {
-               mask = 0x3f;
-               shift = 6;
-       }
-       ret = ((offset + width + mask) >> shift) - (offset >> shift);
-       if (!IS_GEN2(dev_priv))
-               ret <<= 1;
-       ret -= 1;
-       return ret << 2;
+       u32 sw;
+
+       if (IS_GEN2(dev_priv))
+               sw = ALIGN((offset & 31) + width, 32);
+       else
+               sw = ALIGN((offset & 63) + width, 64);
+
+       if (sw == 0)
+               return 0;
+
+       return (sw - 32) >> 3;
 }
 
 static const u16 y_static_hcoeffs[N_HORIZ_Y_TAPS * N_PHASES] = {
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to