Oki, here´s some conclusions. First. The "fix" in question. In 
*ImageTransformsGPU.cpp 
*I change line 465 to:
*const int bytesPerDestPixel = 2 - 2 - 2*
It was before:
const int bytesPerDestPixel = 16 + 16 + 8

This allows for functioning corruptfree output even with files with wdth 
above 6000(pixels?). Big files in other words. THis didn´t work before. I 
cannot see any speed change by doing this and it can be used also with 
other intel machines with nvidia cards and so on. WIth that said I don´t 
see it as a stable fix for all macs. It works on M1 at least.

The gain selecting GPU isn´t all that great but a little speed improvement 
shows. Around two seconds from 8 to 6 when processing aligning on three 
images. Tested both intel(nvidia) and Mac M1. Clearly intel is faster with 
nvidia than rosetta-run processing on M1 so for mac users porting hugin to 
arm64 probably is a must for the future.

Tests using "time" in bash:
GPU processing


*real 0m6.030suser 0m9.579ssys 0m2.777s*
Daniels-MacBook-Pro:~ daniel$

CPU processing


*real 0m7.834suser 0m34.507ssys 0m3.147s*
Daniels-MacBook-Pro:~ daniel$

Compiling almost fully working. I cannot get make package finalize, 
probably my paths are missing or wrong so I need to go through this when I 
have the time to do so.
Otool works good to create portable lib folders so I decided to use this to 
be able and use align_image_stack on other computers after compiled on my 
intel machine:
https://github.com/auriamg/macdylibbundler

All in all, good progress even if the fix is a bit random and unscientific.
/D

fredag 7 april 2023 kl. 18:24:28 UTC+2 skrev Jan Steinman:

> Thank you! I'm on an Intec Mac, and still stuck in 2018 or so with Hugin! 
> I'm looking forward to being able to run a more recent release. Wish I had 
> time to help out on it!
> On Thursday, 6 April 2023 at 03:05:58 UTC-7 [email protected] wrote:
>
>> Hi again :). Progress has been made. First I compiled, at least 
>> align_image_stack and nona, on my intel mac, but gave up on that station 
>> and wnent to my M1 hoping it would solve the gpu issue. Managed to get a 
>> devenvironment running by updating makefiles and checking each dependency 
>> in the mac script and modernized downloads accordingly. Still not getting 
>> 100% configuration with those sources but when lacking I could run brew 
>> install so with a sort of a hybrid system it now compiles and I get so far 
>> as sudo make install and it makes the Hugin.app but then it stops. Good 
>> enough for know.
>>
>> *Fix*
>> Fixing the --GPU issue. I actually found out where the trouble starts and 
>> fixed the issue inside *ImageTransformsGPU.cpp *so now I get corruption 
>> free output when --gpu is enabled. I still need some tinkering to get it 
>> nice in code but what I also need is someone to compile Hugin for mac as 
>> stand alone application. I asked Max already but he might be far away from 
>> his mac recently. Is there anybody else in here that has a Xcode 
>> envrionment ready or do I need to get my hands dirty here also ;).,
>> T.Modes. Are you prividing also mac builds? Would really need to test 
>> this fix in the real app.
>>
>> When I am not taking care of my baby and after som sleep I plan on 
>> providing a clean fix for compiling on M1. Will take som time as I need to 
>> revisit and dig harder into some of the sources but all in good time.
>>
>> lördag 1 april 2023 kl. 18:38:49 UTC+2 skrev dudek53:
>>
>>> Tested download-all.sh script. All downloaded except exiftool which 
>>> lands a package of around 300 bytes. Could be fixed with replacing to this:
>>> https://exiftool.org/Image-ExifTool-12.59.tar.gz
>>>
>>> Anyway. Spent whole day trying to get things compiing on Big sur intel 
>>> mac. Phew. Hard one. I need to look deeper than usual here ;).
>>> Is it by the way possible to compile only align_image_stack and not 
>>> havint oto compile the whole program or is everything chained?
>>>
>>>
>>> lördag 1 april 2023 kl. 15:49:37 UTC+2 skrev T. Modes:
>>>
>>>> Hi Max,
>>>>
>>>> [email protected] schrieb am Freitag, 31. März 2023 um 23:28:51 
>>>> UTC+2:
>>>>
>>>> I made a patch file with all the 
>>>> changes I made to get them to download and build correctly, which I've 
>>>> attached to this email. You might need to make more changes to e.g. 
>>>> outdated URLs. 
>>>>
>>>>
>>>> Thanks for the patch. I committed these changes to the repository.
>>>> Next time please create the patch file as unified diff against the root 
>>>> directory of the repository instead of the mac subdirectory.
>>>> I had do to some modification before the patch applied cleanly.
>>>>
>>>> Thomas
>>>>
>>>>

-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/70e05996-e19e-420a-864f-9c9e46751f7en%40googlegroups.com.

Reply via email to