Hi. Are these numbers applied also to at/nvidia cards or do they apply only for other cards not defined? If applied globally tests show no benefit having larger dest chunks like 16 + 16 + 8. More testes shows too high negative numbers will hang processing, while too high, as we know corrupts framebuffering. Question remains. Could code be made more robust removing or changing behaviour in this particular place?
By the way. What is the real cause of the issue here? söndag 9 april 2023 kl. 09:49:40 UTC+2 skrev T. Modes: > Hi Max > [email protected] schrieb am Sonntag, 9. April 2023 um 07:58:17 UTC+2: > > Oki, here´s some conclusions. First. The "fix" in question. In > *ImageTransformsGPU.cpp > *I change line 465 to: > *const int bytesPerDestPixel = 2 - 2 - 2* > It was before: > const int bytesPerDestPixel = 16 + 16 + 8 > > This allows for functioning corruptfree output even with files with wdth > above 6000(pixels?). Big files in other words. THis didn´t work before. I > cannot see any speed change by doing this and it can be used also with > other intel machines with nvidia cards and so on. WIth that said I don´t > see it as a stable fix for all macs. It works on M1 at least. > > > First bytesPerDestPixel can now become zero or negative (when using other > image formats). This breaks the following calculations or results even in a > crash when dividing by zero. > > From the first runs it was probably that the corruption occurs when using > more than one dest chunk. > So when you decrease bytesPerDestPixel you increase the size of the dest > chunk and so nona/align_image_stack is using only one dest chunk and so the > corruption does not happen. (run none with --debug switch) > So you workaround the issue in your single usecase but don't the fix the > real cause. > > Thomas > -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/3b2060a4-52f1-4f90-bb94-883f8a00dc0en%40googlegroups.com.
