lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r336175969
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java ########## @@ -81,18 +83,21 @@ private final NodeManager nodeManager; private final SCMPipelineMetrics metrics; private final Configuration conf; + private boolean pipelineAvailabilityCheck; + private boolean createPipelineInSafemode; + private Set<PipelineID> oldRatisThreeFactorPipelineIDSet = new HashSet<>(); Review comment: I think we dont need to add the set here and can use the getPipelines(ReplicationType, ReplicationFactor) api in OneReplicaPipelineSafeModeRule for getting the oldPipelineSet. This can be done if startPipelineCreator is called from SCMSafeModeManager. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
