lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS
pipeline creation and destroy through heartbeat commands
URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r336428913
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
##########
@@ -127,9 +141,16 @@ public void setPipelineProvider(ReplicationType
replicationType,
pipelineFactory.setProvider(replicationType, provider);
}
+ public Set<PipelineID> getOldPipelineIdSet() {
+ return oldRatisThreeFactorPipelineIDSet;
+ }
+
private void initializePipelineState() throws IOException {
if (pipelineStore.isEmpty()) {
LOG.info("No pipeline exists in current db");
+ if (pipelineAvailabilityCheck && createPipelineInSafemode) {
+ startPipelineCreator();
Review comment:
Can we move this logic to SCMSafeModeManager itself? This is currently
called via SCMSafeModeManager#exitSafeMode. Also currently startPipelineCreator
if called multiple times will create multiple fixed interval tasks for pipeline
creation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
