lokeshj1703 commented on a change in pull request #29: HDDS-2034. Async RATIS
pipeline creation and destroy through heartbeat commands
URL: https://github.com/apache/hadoop-ozone/pull/29#discussion_r336432275
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java
##########
@@ -190,6 +196,18 @@ public synchronized void validateSafeModeExitRules(String
ruleName,
*/
@VisibleForTesting
public void exitSafeMode(EventPublisher eventQueue) {
+ // Wait a while for as many as new pipelines to be ready
+ if (createPipelineInSafeMode) {
+ long sleepTime = config.getTimeDuration(
+ HddsConfigKeys.HDDS_SCM_WAIT_TIME_AFTER_SAFE_MODE_EXIT,
+ HddsConfigKeys.HDDS_SCM_WAIT_TIME_AFTER_SAFE_MODE_EXIT_DEFAULT,
+ TimeUnit.MILLISECONDS);
+ try {
+ Thread.sleep(sleepTime);
Review comment:
I dont think we should wait for HDDS_SCM_WAIT_TIME_AFTER_SAFE_MODE_EXIT
here. This would delay the exit from safe mode for SCM. This is used in
SafeModeHandler to delay the replication manager from replicating containers
and other cleanup activity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
