Hi,

the commit style did grow on me over the time, but I do not have
particularly strong opinion either way.  Just wanted to react to few
things.

Liam Hupfer <l...@hpfr.net> writes:

> [..]
>
> The commit message’s purpose isn’t to enable people to avoid reading the
> diff; that’s an impossible goal. It’s to contextualize the diff.

One additional benefit is that you can search the git history using
--grep instead of -G.  On repository of Guix' size the difference is
quite noticeable.

> [..]
>
>> Anyways, I’m for simplifying the format for our use case, but let’s not
>> drop it entirely. I think overall our commits look great so its
>> definitely working nicely.
>
> This is partly why I didn’t propose banning the format outright in my
> original message. I don’t want to bother developers who like writing the
> current style (other than the fact that they’ll need to get used to
> seeing commits from others without the rote file enumerations).

Which will sadly nuke the usefulness of --grep.

Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

Reply via email to