On Thu, Jul 03, 2025 at 11:57:39PM +0800, Hilton Chain wrote: > - Require all changes to be submitted first. This is actually enforcing the > commit policy[2].
Actually, the manual does not require all changes to submitted as patches / pull requests: ------ As an exception, some changes considered “trivial” or “obvious” may be pushed directly to the master branch. This includes changes to fix typos and reverting commits that caused immediate problems. This is subject to being adjusted, allowing individuals to commit directly on non-controversial changes on parts they’re familiar with. ------ https://guix.gnu.org/manual/devel/en/html_node/Managing-Patches-and-Branches.html That section is linked to from Commit Policy. So, trivial changes can be pushed without review, as well as non-controversial changes to code that the author is familiar with. Any committer will have the judgement to know what's controversial, or else they shouldn't have been granted commit access and will have it revoked soon enough. I think this is sound policy. Else we spend energy (reviews) or time (wait 1 week) for stuff that doesn't warrant it. Although it can be good practice to apply even trivial changes, test them, etc, to help contributors build their skills. Already, committers are supposed to do work for the project: that's the whole point of giving them commit access. In practice, sometimes we get tired or our lives change and we can no longer work as much on Guix. At that stage, some committers become very focused in their contributions and no longer hang out all day in the Guix project. Others just disappear and we remove them after about 1 year.