Hello Hilton,

Am Thu, Jul 03, 2025 at 11:57:39PM +0800 schrieb Hilton Chain:
>   - Require all changes to be submitted first.  This is actually enforcing the
>     commit policy[2].

indeed I followed the policy after it came out, but we have been having
problems with the tooling: QA was never able to keep up with the volume
of submissions. So in practice, each time it amounted to doing some
additional work for submitting the commit, then waiting for a week and
committing the same changes and doing some additional work for closing
the issue. So I gave up after a while and committed directly as before.
This was helped by the addition of
   guix build -P 1 package-name
that we can run locally.

But I agree that it would be preferable to run all changes as PRs
through QA.

As for the distinction between team members and committers you ask about
in your follow-up, I see a greater responsibility with committers, who
sign the commits. I make sure to go through every commit I push.
And they also have the responsibility (and ability) to react quickly of
their commit poses problems, and at the least revert it if necessary.

Andreas


Reply via email to