Hello Florian, > I submitted a first attempt for g-golf-gtk-4-examples at > <https://bugs.gnu.org/76246> > <https://issues.guix.gnu.org/76246>.
Excellent! I would like to suggest a few things:
1- install location
It seems, iiuc, that you propose to install these examples in the guile
tree, then also add a 'bin' dir somewhere ...
That is not the convention as to where examples should be installed.
Examples are normally installed in
$prefix/share/doc/...
So for g-golf-gtk-4-examples, the location should be:
$prefix/share/doc/g-golf/examples/gtk-4/animated-paintable
$prefix/share/doc/g-golf/examples/gtk-4/animated-paintable.png
...
$prefix/share/doc/g-golf/examples/gtk-4/demos/Makefile
$prefix/share/doc/g-golf/examples/gtk-4/demos/demo-child.scm
$prefix/share/doc/g-golf/examples/gtk-4/demos/demo-layout-2.scm
$prefix/share/doc/g-golf/examples/gtk-4/demos/demo-layout.scm
...
I would highly recommend to follow this well established (and all other distro
respected) convention.
2- synopsis and description
I would prefer
(synopsis "G-Golf Gtk-4 Examples")
;; the -4 is essential here above, we will have -5 ...
(description "G-Golf port of (a subset of) the upstream gtk4-demo
examples")
;; no need to add anything, with all due respect, "show how to ..."
;; is redundant here, as examples do 'show how to' by definition
I was wondering if it would not be wise to add, in the description, something
like
"Please note that in Guix, those examples are being (temporarily)
patched to use/pass the --no-grafts option. Guix G-Golf users must do the same,
till further notice."
> The patch has not reached upstream, but with it, the Guile-Cairo
> commit needed by examples can build in Guix.
Excellent! The patch was not merged because considered a regression,
due to the fact that to fix the bug, I had to remove the fixed location
of the guile-cairo lib, and till I further improve the autotool chain
of guile-cairo, the lib is now installed in $prefix/lib (instead of
GUILE_EXTENSION_PATH). So now guile-cairo users must define/extend
their LD_LIBRARY_PATH so dynamic-link finds the guile-cairo lib (but I
think most, if not all, guile users already have their $prefix/lib as
(one of) the LD_LIBRARY_PATH definition entry.
3- --no-grafts:
> Yes, I guess grafts could be patched in using (with-parameters
> ((%graft? #f)) ...)
I failed to see the --no-grafts patch in your package definition, fwiw
(just curious, I'd like to read an example script patched so it has the
option, so i can answer this faq in #guile, #guix:
could you kindly pasted a patched example somewhere and ping
me, so I could look at it, thanks.
> but strangely the hello-world in the package runs fine even with
> grafts. I do not understand why it affects me elsewhere.
I would patch all examples and 'not bother', till effectively fixed in
guix 'proper'.
Thanks,
David
pgpwPnJ65YQb8.pgp
Description: OpenPGP digital signature
