ng0 <n...@pragmatique.xyz> writes: > Mark H Weaver transcribed 1.2K bytes: >> k...@openmailbox.org (Kei Kebreau) writes: >> >> > kkebreau pushed a commit to branch master >> > in repository guix. >> > >> > commit 0e4591bb696a36bc83f75869dd2711987b17b722 >> > Author: ng0 <n...@no-reply.pragmatique.xyz> >> > Date: Tue May 16 22:28:58 2017 +0000 >> > >> > gnu: Add s. >> > >> > * gnu/packages/shells.scm (s): New variable. >> > >> > Signed-off-by: Kei Kebreau <k...@openmailbox.org> >> > --- >> > gnu/packages/shells.scm | 61 >> > +++++++++++++++++++++++++++++++++++++++++++++++++ >> > 1 file changed, 61 insertions(+) >> > >> > diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm >> > index 5eeb186..5e04e86 100644 >> > --- a/gnu/packages/shells.scm >> > +++ b/gnu/packages/shells.scm >> > @@ -503,6 +503,67 @@ Its features include: >> > @end enumerate\n") >> > (license bsd-2))) >> > >> > +(define-public s >> > + (let ((commit "6604341edb3a775ff94415762af3ee9bd86bfb3c") >> > + (revision "1")) >> > + (package >> > + (name "s") >> > + (version (string-append "0.0.0-" revision "." (string-take commit >> > 7))) >> >> I think we should rename this package and variable name to 's-shell' or >> something along those lines. 's' is commonly used as a local variable >> name. Single character variable names are in short supply, and I don't >> think we should allocate them to packages. >> >> Thoughts? >> >> Mark > > I did not think of this use, renaming to s-shell is okay.
I agree.
signature.asc
Description: PGP signature
