Ludovic Courtès <l...@gnu.org> writes:
>> + (substitute* "src/Makefile.in"
>> + ;; By default, the PYTHONPATH is set to "src/pybind".
>> + ;; Make sure our libraries are found too.
>> + (("export PYTHONPATH=") (string-append "export PYTHONPATH="
>> + (getenv "PYTHONPATH")
>> + ":"))
>
> I’d move (string-append …) on the next line (for the following
> substitutions as well.)I tried that, but actually found this easier to read. :-) Will double-check. >> + ;; Ceph is licensed under LGPL2.1, but includes a number of components >> + ;; covered by other licenses. Consult COPYING for full information. >> + (license (list license:lgpl2.1 >> + license:cc-by-sa3.0 ; documentation >> + license:bsd-2 ; xxHash >> + license:bsd-3 >> + license:gpl3 >> + license:gpl2 >> + license:public-domain >> + license:boost1.0 >> + license:expat)))) > > No “or any later version” clause for the GNU licenses here? Oops, yes, there are some gpl2+ files at least. But Ceph itself is LGPL2.1 only AFAICT; the COPYING file has a debian-style copyright format and adds "or later" on some components but not on '*'. No copyright headers in the source files I've checked. Unfortunately COPYING does not cover the bundled components, so I still have some digging to do. > Then apart from the wrapping that you mentioned in the cover letter and > other issues, that looks good. Great work! Thanks! I'm sure there is a lot of work remaining to make *everything* work (e.g. 'ceph-deploy'), but will make sure it's possible to provision a cluster the "old school" way at least :-)
signature.asc
Description: PGP signature
