Marius Bakke <mba...@fastmail.com> skribis:
> * gnu/packages/distributed-filesystems.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
[...]
> + (substitute* "src/Makefile.in"
> + ;; By default, the PYTHONPATH is set to "src/pybind".
> + ;; Make sure our libraries are found too.
> + (("export PYTHONPATH=") (string-append "export PYTHONPATH="
> + (getenv "PYTHONPATH")
> + ":"))
I’d move (string-append …) on the next line (for the following
substitutions as well.)
> + ;; Ceph is licensed under LGPL2.1, but includes a number of components
> + ;; covered by other licenses. Consult COPYING for full information.
> + (license (list license:lgpl2.1
> + license:cc-by-sa3.0 ; documentation
> + license:bsd-2 ; xxHash
> + license:bsd-3
> + license:gpl3
> + license:gpl2
> + license:public-domain
> + license:boost1.0
> + license:expat))))
No “or any later version” clause for the GNU licenses here?
Then apart from the wrapping that you mentioned in the cover letter and
other issues, that looks good. Great work!
Ludo’.
