Ricardo Wurmus (2016-10-27 16:09 +0200) wrote:
> Roel Janssen <r...@gnu.org> writes:
[...]
>> +(define-public emacs-org-trello
>> + (package
>> + (name "emacs-org-trello")
>> + (version "0.7.9")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://github.com/org-trello/org-trello/archive/";
>> + version ".tar.gz"))
>> + (file-name (string-append name "-" version ".tar.gz"))
>> + (sha256
>> + (base32
>> + "074dka8g673bj1ck5vavbjaij5jyniygdlw51mdds005wd2br9wf"))))
>> + (build-system emacs-build-system)
>> + (propagated-inputs
>> + `(("emacs-deferred" ,emacs-deferred)
>> + ("emacs-request" ,emacs-request)
>> + ("emacs-dash" ,emacs-dash)
>> + ("emacs-s" ,emacs-s)
>> + ("emacs-undercover" ,emacs-undercover)
>> + ("emacs-el-mock" ,emacs-el-mock)
>> + ("emacs-helm" ,emacs-helm)))
>
> Hmm, now I wonder… I just looked at emacs.scm and only one package there
> has “emacs-undercover” as an input (and it looks like this was a
> mistake). We seem not to add test inputs to Emacs packages.
>
> @Alex: could you please confirm this? Should these inputs be mentioned
> at all? If so, is it sufficient to add them to native-inputs?
As for me, I don't see a reason to add these additional inputs,
emacs-build-system will not run tests anyway. I think it is good to
stick only to those dependencies that are listed in a header commentary
(in "org-trello.el") or in a "-pkg.el" file if it presents
("org-trello-pkg.el") – these are the exact dependencies that are used
by (M)ELPA.
I wouldn't bother about the rest emacs packages that are listed in
"Cask" file or are used in some other way by package developers; they
don't add anything useful for the end users.
So I think the original Roel's variant with 4 propagated-inputs is
preferable. The rest dependencies ("undercover", "el-mock" and "helm")
are used only for some developer tools which are not interesting for
users, these tools are even excluded in the MELPA recipe:
<https://github.com/melpa/melpa/blob/master/recipes/org-trello>
--
Alex
